Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create logical separation of Bag samples in Bag examples dir #73

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

ross-spencer
Copy link
Contributor

@ross-spencer ross-spencer commented Feb 28, 2020

This PR creates a separate bag transfer directory with examples of current bags so that all combinations can be tested, and the test suite can be easily added to.

The primary two benefits of this PR are:

  • Adds reference examples of Bag Transfers with CSV metadata.
  • Adds tar.gz transfer support which we should support: here

Chatting to Sara, this PR creates some short-term duplication where AMAUAT is still tightly coupled with other Bag sample data still in the repository. I have proposed we remove this post-1.11 testing where our reliance on AMAUAT is lessened for a short while.

The new layout is as follows:

SampleTransfers/BagExamples$ $ tree -d
.
├── TarGzBags
├── UnzippedBags
│   ├── BaggedDemoTransferCSV
│   │   ├── data
│   │   │   └── artwork
│   │   └── metadata
│   │       └── submissionDocumentation
│   ├── BagTransfer
│   │   └── data
│   │       └── bagTest
│   ├── SimpleBagWithProcessingMCP
│   │   └── data
│   └── UnzippedBag
│       └── data
└── ZippedBags

Connected to archivematica/Issues#771
Connected to archivematica/Issues#851
Connected to archivematica/Issues#859

Closes #66

@ross-spencer ross-spencer force-pushed the dev/add-bag-examples-folder branch from 1cc6a41 to ba09472 Compare February 28, 2020 23:11
@ross-spencer
Copy link
Contributor Author

Fixed up following archivematica/Issues#1123 tar.gz files will work in qa/1.x

@ross-spencer ross-spencer requested a review from sarah-mason March 2, 2020 14:32
Copy link
Contributor

@sarah-mason sarah-mason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Ross! I very much appreciate the organisation of these transfers and the duplication between unzipped and zipped bags. Have you thought about adding detail to the README.MD to just add a bit about what the different sample sets are good for? (not necessary, just wondered)

@ross-spencer
Copy link
Contributor Author

Thanks @sarah-mason. I usually try to, I also had them in the original PR for this but then removed them as I couldn't make them clear enough. But I think it's true now that the purpose of each could be made much clearer in README and I have a clearer picture of that. I can address this later in the week, but if you think this PR will also improve the regression testing experience up-front then we can merge and I can come back to it after that too.

@sarah-mason
Copy link
Contributor

@ross-spencer - I think it will probably sped up regression testing and you are busy this week, so I would say go ahead and merge it. Then come back to the README when you have a little bit more time to think about it. This really meets my need for organisation! 😄

@ross-spencer
Copy link
Contributor Author

Alright! Merging, and placing the note to add README at the top of my list for the moment I have some down-time.

Thank you Sarah! 🙇

@ross-spencer ross-spencer merged commit ba09472 into master Mar 4, 2020
@ross-spencer ross-spencer deleted the dev/add-bag-examples-folder branch March 4, 2020 14:02
@ross-spencer ross-spencer mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants