Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: cannot add items to clipboard #1783

Closed
nicdub opened this issue Mar 26, 2024 · 1 comment · Fixed by #1784
Closed

Problem: cannot add items to clipboard #1783

nicdub opened this issue Mar 26, 2024 · 1 comment · Fixed by #1784
Assignees
@anvit
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Milestone
2.8.2

Comments

@nicdub
Copy link

nicdub commented Mar 26, 2024

Current Behavior

Steps to reproduce the behavior

  1. Find any entry
  2. Click Add to Clipboard
  3. Nothing is added to the clipboard and we can see this error in the console:
 Uncaught TypeError: this.items is null
 toggle http://localhost:63001/js/clipboard.js:351

Expected Behavior

The item should be added to the clipboard...

Possible Solution

The problem seems to have appeared in this commit: Fix clipboard storage behaviour (#1749) (9cf5ac4)

Context and Notes

No response

Version used

AtoM 2.8.1

Operating System and version

Ubuntu 22.04

Default installation culture

en

PHP version

PHP 7.4

Contact details

No response
@nicdub nicdub added the Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. label Mar 26, 2024
@anvit anvit added this to the 2.9.0 milestone Mar 26, 2024
@anvit
Copy link
Contributor

anvit commented Mar 26, 2024

@nicdub Thanks for reporting this bug!

@anvit anvit self-assigned this Mar 26, 2024
anvit added a commit that referenced this issue Mar 26, 2024
@anvit
Fix clipboard for empty browser cache (#1783)
a842c30 
Set browser local storage values for clipboard if their corresponding
variables are null on load, which happens if the browser storage is
cleared.
@anvit anvit linked a pull request Mar 26, 2024 that will close this issue
Fix clipboard for empty browser cache (#1783) #1784
Merged
anvit added a commit that referenced this issue Mar 27, 2024
@anvit
Fix clipboard for empty browser cache (#1783)
412a0eb 
Set browser local storage values for clipboard if their corresponding
variables are null on load, which happens if the browser storage is
cleared.
anvit added a commit that referenced this issue Mar 27, 2024
@anvit
Fix clipboard for empty browser cache (#1783)
c0ef72e 
Set browser local storage values for clipboard if their corresponding
variables are null on load, which happens if the browser storage is
cleared.
@anvit anvit modified the milestones: 2.9.0, 2.8.2 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anvit anvit

Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Milestone
2.8.2
Development

Successfully merging a pull request may close this issue.

Fix clipboard for empty browser cache (#1783) artefactual/atom
2 participants
@anvit @nicdub