Automatically orient scaled images (#13606) #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My commit references an issue on the old issue server. Do I need to make an issue on GitHub then change the number to that? |
mcantelon
force-pushed
the
dev/image-scale-auto-orientation
branch
from
178976a to
ad6534a
Compare
mcantelon
added
the
Type: bug
anvit
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Looks good! @mcantelon I don't think there's a need to make a new GitHub issue for that, but maybe change the commit to say ref#13606 (without parenthesis, like the old commit format) to avoid GitHub from trying to connect it to an issue here?
|
FYI @mcantelon it is the reference image that is most often affected by this issue. Will this address possible rotation issues for both, or just the thumbnail? |
|
@fiver-watson It should be for all scaling. |
|
@anvit Thanks Anvit... good catch... I'll amend the commit message before merging! |
Added option to ImageMagick convert tool to automatically orient scaled images.
mcantelon
force-pushed
the
dev/image-scale-auto-orientation
branch
from
ad6534a to
70c797c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to ImageMagick convert tool to automatically orient scaled images.