Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translationLinksComponent dropdown (#1805) #1806

Merged
merged 1 commit into from
May 3, 2024

Conversation

anvit
Copy link
Contributor

@anvit anvit commented Apr 30, 2024

The $translations variable in translationLinksComponent needs to be a property of $this in order to accessible by the template. Also adding in a currentCulture flag to the getOtherCulturesAvailable method so that the current culture can be excluded from the results.

The $translations variable in translationLinksComponent needs to be a
property of $this in order to accessible by the template. Also adding in
a currentCulture flag to the getOtherCulturesAvailable method so that
the current culture can be excluded from the results.
@anvit anvit added the Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. label Apr 30, 2024
@anvit anvit added this to the 2.9.0 milestone Apr 30, 2024
@anvit anvit requested a review from a team April 30, 2024 23:40
@anvit anvit self-assigned this Apr 30, 2024
@anvit anvit linked an issue Apr 30, 2024 that may be closed by this pull request
Copy link
Member

@djjuhasz djjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mcantelon pushed a commit that referenced this pull request May 2, 2024
Added functionality, to the digital object load task, to import URLs in
addition to files.
mcantelon pushed a commit that referenced this pull request May 2, 2024
Added functionality, to the digital object load task, to import URLs in
addition to files.

Did minor cleanup and improved CLI help to include a list of valid CSV
columns.
@anvit anvit merged commit d06b2d3 into qa/2.x May 3, 2024
6 checks passed
@anvit anvit deleted the dev/1805-other-language-dropdown branch May 3, 2024 17:29
@anvit anvit modified the milestones: 2.9.0, 2.8.2 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: Other language dropdown is empty
2 participants