Refactors amclient.py

* Creates new logging configuration script to reduce redundancy
* Separates responsibility of amclient, defaults, and cli args
* Cleans up argparse output using metavar
* Adds Conformity to PEP8 to amclient.py and transfers.py
* Returns user friendly string via getattr if function call fails in main
* Improved error return from JSON request function in amclient.py
* Adds .db and .lck files to .gitignore
* Works at module and executable level
* E402 flake8 warning ignored in Tox to enable module/exe to work
* Captures connection errors in transfers.py better
* Initial changes provides scope for future refactoring as required
* Addresses #47

.gitignore

@@ -10,5 +10,14 @@
 # Sublime files
 *.sublime-*
 
+# Log files
 *.log.[0-9]
+*.log
+
+# Tox files
 .tox/
+
+# Script generated files
+*.db
+*.lck
+

requirements/base.txt

@@ -2,3 +2,4 @@ metsrw==0.2.0
 requests<3.0
 sqlalchemy
 six
+urllib3

tests/test_amclient.py

@@ -1,4 +1,3 @@
-#!/usr/bin/env python
 """To run the tests::
 
     $ python -m unittest tests.test_amclient
@@ -11,6 +10,7 @@
 import vcr
 
 from transfers import amclient
+from transfers import errors
 
 
 AM_URL = 'http://192.168.168.192'
@@ -24,6 +24,7 @@
 
 
 class TmpDir:
+
     """Context manager to clear and create a temporary directory and destroy it
     after usage.
     """
@@ -118,7 +119,7 @@ def test_completed_transfers_bad_key(self):
         completed_transfers = amclient.AMClient(
             am_api_key='bad api key', am_user_name=AM_USER_NAME,
             am_url=AM_URL).completed_transfers()
-        assert completed_transfers is None
+        assert completed_transfers is errors.ERR_INVALID_RESPONSE
 
     @vcr.use_cassette(
         'fixtures/vcr_cassettes/unapproved_transfers_transfers.yaml')

tox.ini

@@ -19,4 +19,5 @@ commands = flake8 .
 exclude = .git, .tox, __pycache__, old, build, dist
 ignore =
     E501  # Lines are too long
+    E402  # Module level imports not at top of file
 import-order-style = pep8