fix: prevent resource leaks in mouse event handling #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a resource leak in the mouse event handling code that could cause input lag over time.
This should fix #111
Changes:
unregisterMouseCallback
Technical Details:
The fix addresses the ownership of Core Foundation objects created with
CGEventTapCreate
andCFMachPortCreateRunLoopSource
. These functions return objects with +1 retain count that need to be properly released to prevent resource leaks.Impact:
This should prevent the accumulation of unused event taps and run loop sources when listeners are restarted (e.g. after sleep/wake cycles), improving long-term performance and preventing potential input lag.