Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to not send middle clicks to specific applications #91

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SilverEzhik
Copy link

This PR adds the ability to not send middle clicks to specific applications.

This can resolve #90, as well as issues in any other apps where it might not be beneficial to send middle click events. For example, Microsoft Remote Desktop will send a middle click on a three finger tap when connected to a remote machine, which can cause a double middle click.

This works by adding a new Defaults key containing an array of app bundle identifiers to ignore:

defaults write com.rouge41.middleClick ignoredAppBundles -array com.microsoft.rdc.macos com.apple.Terminal

@artginzburg
Copy link
Owner

This makes a lot of sense and would be a nice improvement to the app! My only concern is that there's already too much configuration available to the user.

My initial goal was for this app to be unnoticeable and invisible, as if middle-click just worked in macOS out of the box.

If we do add such extensive configuration, it starts to make sense to implement a settings menu, so that the user never needs to open a terminal to configure this basic system feature. The very notion of opening a terminal might be off-putting for many users.

@SilverEzhik
Copy link
Author

On the other hand, even Apple themselves are not a stranger to keeping some power user configuration options to defaults. I guess it really depends on how often we see people actually using this? It might even make sense to ship a default option that excludes some apps that cause problems (like RDP which has its own middle click gesture for example).

Configuring this one might be tough with a menu though, might take a full UI that'd look something like the "Open at Login" list of apps in the "Login Items & Extensions" section of the System Settings app.

@artginzburg
Copy link
Owner

Keeping this in defaults until more users ask for a UI seems fair.

Now, shipping a default option is a great idea, let's do that. Do you remember anything other than RDP that should be in the ignore list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable paste selected-text in terminal
2 participants