Skip to content
This repository has been archived by the owner on Dec 26, 2023. It is now read-only.

Strange path on windows #14

Closed
Den-dp opened this issue Jul 13, 2017 · 2 comments
Closed

Strange path on windows #14

Den-dp opened this issue Jul 13, 2017 · 2 comments

Comments

@Den-dp
Copy link

Den-dp commented Jul 13, 2017

Looks like on Windows we need to convert windows backslash paths to slash paths, because of this:

double-back slashes here
image

back-slashes
image

no icons
image

Here is simple repro https://github.com/Den-dp/webpack-pwa-manifest-example

Thanks
arthurbergmz added a commit that referenced this issue Jul 13, 2017
@arthurbergmz
Fixed issue #14
1a03750
@arthurbergmz
Copy link
Owner

Oops, my bad! "path.join" shouldn't be used for joining URI.
Fixed. Please, update to v3.1.2.

Thank you!

@Den-dp
Copy link
Author

Den-dp commented Jul 14, 2017

@arthurbergmz Great! Works for me! Thanks for responding to this so quickly. I really appreciate it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Den-dp @arthurbergmz