Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure CI to publish crate version on master branch build #8

Closed
arthurkhlghatyan opened this issue Jan 2, 2021 · 7 comments · Fixed by #7
Closed

Configure CI to publish crate version on master branch build #8

arthurkhlghatyan opened this issue Jan 2, 2021 · 7 comments · Fixed by #7
Labels
bug Something isn't working enhancement New feature or request

Comments

@arthurkhlghatyan
Copy link
Owner

No description provided.

@arthurkhlghatyan arthurkhlghatyan added the enhancement New feature or request label Jan 2, 2021
@arthurkhlghatyan arthurkhlghatyan linked a pull request Jan 2, 2021 that will close this issue
Publish V1.0 #7
Merged
arthurkhlghatyan added a commit that referenced this issue Jan 2, 2021
@arthurkhlghatyan
Minor changes
9b99843 
- Configure CI to publish crate version on master branch build #8
- Add missing fields for GraphQLErrorMessage struct #4: Still need to specify path field
- Rollback tokio to v0.2 for now
arthurkhlghatyan added a commit that referenced this issue Jan 5, 2021
@arthurkhlghatyan
Publish V1.0 (#7)
21fb877 
* Ensure web assembly support in CI #2

* Add Code of Conduct #3

* Upgrade version of Tokio to 1.0 #5: Need to also upgrade reqwest

* Minor changes
- Configure CI to publish crate version on master branch build #8
- Add missing fields for GraphQLErrorMessage struct #4: Still need to specify path field
- Rollback tokio to v0.2 for now

* Minor changes
- Final struct representation #4
- Upgrade to tokio V1 but still doesn't work #5

* #5 Upgrade to reqwest 0.11 to support tokio v1

* Fix formatting
arthurkhlghatyan added a commit that referenced this issue Jan 5, 2021
@arthurkhlghatyan
Release V1.0 - Fixed missing version number change in Cargo.toml (#9)
83ea785 
* Ensure web assembly support in CI #2

* Add Code of Conduct #3

* Upgrade version of Tokio to 1.0 #5: Need to also upgrade reqwest

* Minor changes
- Configure CI to publish crate version on master branch build #8
- Add missing fields for GraphQLErrorMessage struct #4: Still need to specify path field
- Rollback tokio to v0.2 for now

* Minor changes
- Final struct representation #4
- Upgrade to tokio V1 but still doesn't work #5

* #5 Upgrade to reqwest 0.11 to support tokio v1

* Fix formatting

* Update version number
arthurkhlghatyan added a commit that referenced this issue Jan 5, 2021
@arthurkhlghatyan
Fix build fail for v1.0 (#10)
48a822d 
* Ensure web assembly support in CI #2

* Add Code of Conduct #3

* Upgrade version of Tokio to 1.0 #5: Need to also upgrade reqwest

* Minor changes
- Configure CI to publish crate version on master branch build #8
- Add missing fields for GraphQLErrorMessage struct #4: Still need to specify path field
- Rollback tokio to v0.2 for now

* Minor changes
- Final struct representation #4
- Upgrade to tokio V1 but still doesn't work #5

* #5 Upgrade to reqwest 0.11 to support tokio v1

* Fix formatting

* Update version number

* Add change log vor V1
@arthurkhlghatyan
Copy link
Owner Author

Still encountering problems in build. Asked the question in this thread.

@arthurkhlghatyan arthurkhlghatyan added the bug Something isn't working label Jan 13, 2021
@arthurkhlghatyan
Copy link
Owner Author

Currently, build is failing because dpl is trying to publish crate on each successful job completion.

@arthurkhlghatyan
Copy link
Owner Author

Hey, @fewensa have you been able to use Travis for crate publishing before?

@fewensa
Copy link
Collaborator

fewensa commented Mar 12, 2022

Hey, @fewensa have you been able to use Travis for crate publishing before?

I'm not use Travis, but I can modify use github actions and create a pull request, if you want switch use github action.

@fewensa fewensa mentioned this issue Mar 12, 2022
Merged
@arthurkhlghatyan
Copy link
Owner Author

Hey @fewensa,

Huge thank you for this update and I will merge this later today or tomorrow (My timezone - in GST)

I couldn't find a way to reach out to you, would you be able to jump on a call with me this week to discuss how we could make the library better and also get to know each other?

Also worth mentioning I added you as a collaborator to the project and the invite is still pending, let me know if I should re-send.

Arthur.

@arthurkhlghatyan
Copy link
Owner Author

Hey @fewensa seems there's a problem in configuration syntax. Feel free to open another PR or I can check this in the morning.

@fewensa fewensa mentioned this issue Jun 26, 2022
Merged
arthurkhlghatyan pushed a commit that referenced this issue Jun 26, 2022
@fewensa
Check response code and fix ci (#20)
bb9b426 
* Helpful log (#7)

* test

* check response

* more helpful log

* Try fix ci (#8)

* Change CI use Github actions and bump version to 1.0.5 (#17)

* Fix CI

* Better CI job name

* Lint

* Fix Test

* Bump v1.0.6
@fewensa
Copy link
Collaborator

fewensa commented Jun 27, 2022

Fixed

@fewensa fewensa closed this as completed Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Publish V1.0 arthurkhlghatyan/gql-client-rs
2 participants
@arthurkhlghatyan @fewensa