Update mapping::lookup so it is a const function #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lopopolo
added
A-performance
|
This is blocked on rust-lang/rust#79549 which makes |
lopopolo
added
the
S-blocked
|
It looks like I came to this same conclusion in #17, but now there is a PR up in upstream Rust, so I'll keep this open. |
lopopolo
added a commit
that referenced
this pull request
Dec 30, 2020
This commit does everything except add the `const` annotation to the function signature. Adding `const` is blocked on rust-lang/rust#79549. See #49.
lopopolo
force-pushed
the
const-lookup
branch
from
a98ce43 to
70bd64e
Compare
|
This will be unblocked once rust-lang/rust#82078 makes it to stable. |
|
The required const fn changes were released in Rust 1.52.0: https://blog.rust-lang.org/2021/05/06/Rust-1.52.0.html#stabilized-apis |
lopopolo
removed
the
S-blocked
Rust 1.52.0 stabilized several char ASCII methods as const which are required by `lookup` if we wish to make `lookup` const. https://blog.rust-lang.org/2021/05/06/Rust-1.52.0.html#stabilized-apis This commit adds a job to the CI GitHub Actions workflow to test foccacia with the declared MSRV of 1.52.0. Due to several panics in incremental compilation in Rust 1.52.0, this job sets the `CARGO_INCREMENTAL` env variable to 0 to disable incremental compilation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raises the minimum Rust version to 1.46.0, adds docs for MSRV, and a CI job to ensure
focacciacompiles with Rust 1.46.0.