Skip to content
This repository has been archived by the owner on Jun 14, 2021. It is now read-only.

Document the need for lifecycle argument #327

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

zoltanpeto
Copy link

When managing application group assignments via app_group_assignment resource
the application resource's group management must be disabled using lifecycle.ignore_changes
attribute to avoid removal of externally added assignments. Same applies
to app_user resource.

While this behaviour is shown in examples, it is best to warn users by
adding this to docs too.

See #322

… and `app_user`

When managing application group assignments via `app_group_assignment` resource
the application resource's group management must be disabled using `lifecycle.ignore_changes`
attribute to avoid removal of externally added assignments. Same applies
to `app_user` resource.

While this behaviour is shown in examples, it is best to warn users by
adding this to docs too.

See #322
@quantumew quantumew self-requested a review November 12, 2019 13:26
Copy link
Contributor

@quantumew quantumew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this!!

@quantumew quantumew merged commit bfb2bc4 into articulate:master Nov 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants