Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth2): PR follow-ups #10898

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix(auth2): PR follow-ups #10898

merged 1 commit into from
Oct 7, 2024

Conversation

damassi
Copy link
Member

@damassi damassi commented Oct 7, 2024

Description

Quick follow-ups to #10896

@damassi damassi requested a review from araujobarret October 7, 2024 13:58
@damassi damassi self-assigned this Oct 7, 2024

const translateY = (() => {
const translateY = useMemo(() => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better 🙏

@ArtsyOpenSource
Copy link
Contributor

Warnings
⚠️

An error occurred while validating your changelog, please make sure you provided a valid changelog.

Generated by 🚫 dangerJS against 0a27e7f

@damassi damassi added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Oct 7, 2024
@@ -59,7 +60,7 @@ export const AuthModal: React.FC = ({ children }) => {
}}
style={{
width: "100%",
backgroundColor: "white",
backgroundColor: color("white100"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏

@artsy-peril artsy-peril bot merged commit 7dee1b9 into main Oct 7, 2024
7 checks passed
@artsy-peril artsy-peril bot deleted the damassi/fixes branch October 7, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants