fix: purchase button disappears #11492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brainbicycle
added a commit
that referenced
this pull request
Feb 5, 2025
* get rid of now unused native-code-version * update license date * don't support redirecting to home from webview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves PBRW-412
Description
This is a workaround for the purchase button disappearing after tapping the artsy logo in the purchase flow.
This is happening because this logo redirects to https://www.artsy.net which maps to the Home module, so under the modal navigation happens and this breaks the display of the artwork page. This just prevents navigation in this case.
Follow-up:
This is not a great solution I think it would be better to remove the artsy logo or make tapping a no-op when visiting the checkout pages from Eigen in force.
Screenshots
Before
before-low.mov
After
after-low.mov
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.