Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ONYX-1516): fix null in auction result screen header, and spacing on the auctions screen #11510

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dariakoko
Copy link
Contributor

@dariakoko dariakoko commented Feb 7, 2025

This PR resolves ONYX-1516

Description

Fix:

  • null value is showing up on the auction result header
  • sales screen layout is incorrect (big white space under the header)
Before After Before After
image image image image

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • fix null in auction result screen header, and spacing on the auctions screen

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@dariakoko dariakoko self-assigned this Feb 7, 2025
@dariakoko dariakoko changed the title fix(ONYX-1516): fix auction result header, and spacing fix(ONYX-1516): fix null in auction result screen header, and spacing on the auctions screen Feb 7, 2025
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Feb 7, 2025

This PR contains the following changes:

  • Cross-platform user-facing changes (fix null in auction result screen header, and spacing on the auctions screen - dariakoko)

Generated by 🚫 dangerJS against 3cb0285

…-on-the-auction-result-header-sales-screen-layout-is-incorrect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants