Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BBAN structure for 3 registered and 11 unregistered IBAN countries #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

reva
Copy link

@reva reva commented Dec 13, 2016

I added some missing countries, three of which are described in the official ISO-13616 document. The rest are as described in the IBAN Wikipedia article, for which the source is the Nordea bank. (The codes for Ukraine and Iran were already included from that source)

@coveralls
Copy link

coveralls commented Dec 13, 2016

Coverage Status

Coverage increased (+0.02%) to 99.067% when pulling d6f926c on reva:master into ce1ca12 on arturmkrtchyan:master.

@arturmkrtchyan
Copy link
Owner

@reva thanks for your contribution. Can you please add test data as well ? See the example here: https://github.com/arturmkrtchyan/iban4j/blob/master/src/test/java/org/iban4j/TestDataHelper.java#L26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants