Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix install script #9

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Fix install script #9

wants to merge 18 commits into from

Conversation

RickBarretto
Copy link
Collaborator

@RickBarretto RickBarretto commented Nov 23, 2024 •
edited
Loading

I fixed the installation script.
Basically this was mismatching our gzip file pattern.

I fixed the grep's and cp's usage.

I also saved the file with LF format instead of CRLF, by using dos2unix tool.

@RickBarretto
add hashbang
d556fe9
@RickBarretto
add flag exit on error flag
4cc67e3 
this should exit on first error
@RickBarretto
add API_URL as variable
cfed168
@RickBarretto
refactor and fix download function
46fd965 
1. make this clear to read
2. fix unmatched pattern
@RickBarretto
set download msys2 exclusively for windows
a1c9690 
So, we don't need to deal with .zip files.
Instead, zip downloads should be made using Poweshell script...
@RickBarretto
this should install on /home/$USER directory for MSYS2.
4da3c05
@RickBarretto
Merge branch 'main' into main
308bed9
@RickBarretto
fix minor merge conflict
7fb84b4
@RickBarretto
fix copying files issues
e03f2cd
@RickBarretto
add semantic arguments to curl
2d13fe8
@RickBarretto
add meaninful documentation for tar usage
4450c49
@RickBarretto
add missing term to documentation
44f5e78
@RickBarretto
add semantic arguments in get_download_url function
961a8c8
@RickBarretto
add semantic arguments to curl
78cba90
@RickBarretto
format code to improve readability
a3c2132
@RickBarretto
make create_tmp_directory more readable
111aea4
@RickBarretto
make create_directory more readable using long options
7025370
@RickBarretto RickBarretto changed the title [WIP] Fix install script Fix install script Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drkameleon drkameleon Awaiting requested review from drkameleon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RickBarretto