Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
roachtest: collect qps metrics over longer window in gracefuldrain test
The gracefuldrain test was modernized in cf30717. Prior to that commit, QPS metrics were collected over a 10s interval, whereas the modernization refactor changed this to 1 second intervals. Looking at a few recent test failures, I see QPS metrics above the failure threshold, which makes me think suspect that this 1s interval is causing the sorts of inaccuracies MeasureQPS warns against. Also See cockroachdb#133020 (comment). One thing that doesn't line up is the timeline of this tests failure and cf30717. Still, this patch changes the metric's interval back to 10s. References cockroachdb#133020 Release note: None
- Loading branch information