Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for pelican 4 #40

Merged
merged 1 commit into from
Jan 3, 2019
Merged

update for pelican 4 #40

merged 1 commit into from
Jan 3, 2019

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Dec 20, 2018

Hi,

According to pelican's doc:

If upgrading from 3.7.x or earlier, please note that slug-related settings in 4.0+ use {slug} and/or {lang} rather than %s. If %s-style settings are encountered, Pelican will emit a warning and fall back to the default setting. Some user-submitted themes might try to format setting values but fail upon site build with a TypeError. In such cases, the theme needs to be updated. For example, instead of TAG_FEED_ATOM|format(tag.slug), use TAG_FEED_ATOM|format(slug=tag.slug)

This PR fixed build in my case.

@amorphic
Copy link

amorphic commented Jan 2, 2019

Would be great to get this merged. I just updated my blog to use Attila with Pelican 4 and came across this same issue.

@arulrajnet
Copy link
Owner

arulrajnet commented Jan 2, 2019 via email

@arulrajnet arulrajnet merged commit 6fce828 into arulrajnet:master Jan 3, 2019
@arulrajnet
Copy link
Owner

Updated the demo site with the fix http://attila.demo.arulraj.net/tag/general/

amorphic added a commit to amorphic/attila that referenced this pull request Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants