Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update og.html #46

Merged
merged 3 commits into from
Sep 18, 2022
Merged

Conversation

DevinCharles
Copy link
Contributor

Fix for HOME_COVER feature upgrade.

Fix for HOME_COVER feature upgrade.
Copy link
Owner

@arulrajnet arulrajnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove setting default_cover if nothing has set.

line 14 in og.html

refer https://github.com/arulrajnet/attila/pull/45/files

@DevinCharles
Copy link
Contributor Author

I thought this solved the issue, but it's still not quite fixed... If you use HOME_COVER now it overwrites the image on all pages... I'll need to take a look at it again.

@arulrajnet arulrajnet changed the base branch from master to 1.5-pre-release September 18, 2022 15:20
@arulrajnet arulrajnet merged commit 378c130 into arulrajnet:1.5-pre-release Sep 18, 2022
arulrajnet added a commit that referenced this pull request Sep 18, 2022
* Allow to left out google fonts (#65)

* Allow to left out google fonts

* insert comment into if clause

* Update og.html (#46)

* Update og.html

Fix for HOME_COVER feature upgrade.

* use of HOME_COVER everywhere

Co-authored-by: Arul <[email protected]>
Co-authored-by: Arul <[email protected]>

Co-authored-by: Febell <[email protected]>
Co-authored-by: Devin Prescott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants