Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
ngx_rtmp_notify_commands
for different events such ason_connect
oron_publish
, we want to notify an authentication service.We use these directives in the
nginx.conf
and provide the URL of the authentication service.However it doesn't work when the authentication service is using
https
.This is because the
ngx_rtmp_notify_parse_url
inngx_rtmp_notify_module.c
method does NOT handle https.I propose a very simple fix:
This fix is very similar to these:
https://mailman.nginx.org/pipermail/nginx-devel/2013-August/004065.html
https://github.com/kaltura/nginx-aws-auth-module/blob/dbbac974f0699328a63f497cd911a4f991faed9b/ngx_http_aws_auth_module.c#L992-L1009