Add key bindings to jump to the next item of the same kind #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arxanas
requested changes
May 11, 2024
There was a problem hiding this comment.
comment:
- The scroll keybindings come directly from Vim (sorry, meant to comment that one of your other PRs but didn't have time), so I'd prefer to preserve them for now.
- I'm okay with adding the more sane scrolling keybindings that you specified alongside them.
- If you know any other interesting paradigms for these shortcuts (Emacs, Sublime Text, IntelliJ, VS Code, ...) I'm open to supporting them as well.
For now, I'm okay with changing page-up/-down to match Mercurial, but we may want to do a holistic reworking of all the keybindings at some point in the future.
|
Thanks for the feedback! Agreed that this should probably be refactored a bit, I just wanted to get something up as a proposal. I'll be afk for the next week but when I get back I'll push a new revision. |
emesterhazy
force-pushed
the
push-nlzzzsuuruwt
branch
3 times, most recently
from
2ade904 to
d452041
Compare
|
Ok this is ready for another look. Thanks! |
arxanas
approved these changes
Jun 15, 2024
|
I queued #46 for merge; you might have to rebase/update tests. |
This changes the bindings as follows: For page up: - Before: page-up OR ctrl-b - After: ctrl-page-up OR ctrl-b For page down: - Before: page-down OR ctrl-f - After: ctrl-page-down OR ctrl-f The page-up and page-down keys will be repurposed in a subsequent commit to jump between editable sections.
These new keybindings are added alongside the existing keybindings. For scroll up: - Before: ctrl-y - After: ctrl-y OR ctrl-up For scroll down: - Before: ctrl-e - After: ctrl-e OR ctrl-down
For example, if the currently highlighted row is a section header, the page down key will jump to the next section. If the currently highlighted row is a line change, the page down key will jump to the next selectable line. The new keybindings are page-up and page-down.
emesterhazy
force-pushed
the
push-nlzzzsuuruwt
branch
from
d452041 to
96a2db2
Compare
|
Thanks for reviewing! |
|
Nit: the corresponding "feature wishlist" item in the readme is still around. Line 46 in 5cdf339 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
This works well, but probably needs a little bit of polish before submission. Hopefully this can unblock #39 which allows the user to collapse sections using the "focus outward" keybindings (i.e. the left arrow key).