Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview of images with Antora #1366

Closed
sturtison opened this issue May 29, 2023 · 4 comments
Closed

Preview of images with Antora #1366

sturtison opened this issue May 29, 2023 · 4 comments
Labels

Comments

@sturtison
Copy link

Observed vs. expected behavior

Expected image:./image.png[] and image::./image.png[] to both display image.png in the preview. Instead:

  • The inline image macro image:./image.png[] previewed the image.
  • The block image macro image::./image.png[] did not.

Steps to reproduce

Create an Antora component with mirrored paths under both images and pages family folders.

Files

antora.yml
modules/doc/nav.adoc
modules/doc/pages/2023/05/24/feature-x/index.adoc
modules/doc/images/2023/05/24/feature-x/image.png

Test file index.adoc

= Test relative paths

images:./image.png[]

images::./image.png[]

Environment

Windows 10 lastest.

Plugin Version: 0.38.17

PyCharm 2022.2.3 (Community Edition)
Build #PC-222.4345.23, built on October 10, 2022
Runtime version: 17.0.4.1+7-b469.62 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 10 10.0
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 12
Non-Bundled Plugins:
com.samdark.intellij-visual-studio-code-dark-plus (2.7)
com.markskelton.one-dark-theme (5.7.4)
com.jetbrains.darkPurpleTheme (1.3)
com.github.dinbtechit.vscodetheme (1.8.0)
com.fernandojimenez.mattecarbon.theme (3.0.0)
org.asciidoctor.intellij.asciidoc (0.38.17)

IntelliJ Details: PyCharm Community Edition

Thankyou for an awesome plugin.

Best regards, Sturt

@sturtison sturtison added the bug label May 29, 2023
@ahus1
Copy link
Contributor

ahus1 commented May 30, 2023

Thanks for reporting this and sorry this caused you troubles.

With the test case you provided, I was able to create a test case and fix the issue. It will be available in the next release of the plugin. I'll update this issue once a pre-release is available.

@sturtison
Copy link
Author

Thanks for reporting this and sorry this caused you troubles.

With the test case you provided, I was able to create a test case and fix the issue. It will be available in the next release of the plugin. I'll update this issue once a pre-release is available.

Thank you for looking at the matter and for developing such a good plugin.

@ahus1
Copy link
Contributor

ahus1 commented Jun 1, 2023

@sturtison - It's always a great maintainer's experience when bug reports come with a test case. Thanks for spotting this problem, the relative paths have been added only lately and incrementally.

@ahus1
Copy link
Contributor

ahus1 commented Jun 1, 2023

The pre-release 0.38.18 is now available which fixes this bug. Please give it a try if it works for you as expected.

The pre-release of the plugin is available from GitHub releases and the IntelliJ AsciiDoc EAP repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants