Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix maven-source-plugin configuration for releases #644

Closed
2 tasks done
abelsromero opened this issue May 28, 2023 · 1 comment · Fixed by #645
Closed
2 tasks done

Fix maven-source-plugin configuration for releases #644

abelsromero opened this issue May 28, 2023 · 1 comment · Fixed by #645
Labels
bug infrastructure
Milestone
2.2.4

Comments

@abelsromero
Copy link
Member

abelsromero commented May 28, 2023 •
edited
Loading

maven-source-plugin v3.3.0 introduces a new validation that highlighted a configuration error in the pom.
The error caused the sources to be added twice, this causes no issues because it's the same sources artifacts, but it's something that should be fixed.

    [INFO] <<< source:3.3.0:jar (attach-sources) < generate-sources @ asciidoctor-maven-plugin <<<
    [INFO] 
    [INFO] 
    [INFO] --- source:3.3.0:jar (attach-sources) @ asciidoctor-maven-plugin ---
    [INFO] Building jar: /home/asalgadr/temp/asciidoctor-maven-plugin/target/checkout/target/asciidoctor-maven-plugin-2.2.4-sources.jar
    [INFO] 
    [INFO] --- source:3.3.0:jar-no-fork (attach-sources) @ asciidoctor-maven-plugin ---
    [ERROR] We have duplicated artifacts attached.
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD FAILURE
    [INFO] ------------------------------------------------------------------------

Fixed branched:
@abelsromero abelsromero added this to the 2.2.4 milestone May 28, 2023
@abelsromero
Copy link
Member Author

Fixed directly in v2.2.x branch with commit c4082e0 as part of quick fix for v2.2.4 release based on documentation https://central.sonatype.org/publish/publish-maven/#javadoc-and-sources-attachments.

abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this issue May 28, 2023
@abelsromero
Fix maven-source-plugin configuration for release
1561691 
Else, an error reporting the plugin is run twice is shown.

Fixes asciidoctor#644
@abelsromero abelsromero mentioned this issue May 28, 2023
Merged
7 tasks
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this issue May 28, 2023
@abelsromero
Fix maven-source-plugin configuration for release
f08968a 
Else, an error reporting the plugin is run twice is shown.

Fixes asciidoctor#644
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this issue May 28, 2023
@abelsromero
Fix maven-source-plugin configuration for release
6944a13 
Else, an error reporting the plugin is run twice is shown.

Fixes asciidoctor#644
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this issue May 28, 2023
@abelsromero
Fix maven-source-plugin configuration for release
dac8f35 
Else, an error reporting the plugin is run twice is shown.

Fixes asciidoctor#644
abelsromero added a commit that referenced this issue May 29, 2023
@abelsromero
Fix maven-source-plugin configuration for release (#645)
6859101 
Else, an error reporting the plugin is run twice is shown.

Fixes #644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug infrastructure
Projects
None yet
Milestone
2.2.4
Development

Successfully merging a pull request may close this issue.

Fix maven-source-plugin configuration for release abelsromero/asciidoctor-maven-plugin
1 participant
@abelsromero