Fixes conversion failure when using erb template #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
fix-converting-with-erb-templates
branch
from
289d8fb to
bfea074
Compare
Internally erubi option was set as null which caused Asciidoctor to fail with 'Unknown ERB implementation'. The fix sets the option only when a non empty value is present, delegating to AsciidoctorJ default which is 'erb' (consistent with current docs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally eruby option was set as null which caused Asciidoctor to fail with 'Unknown ERB implementation'.
The fix sets the option only when a non empty value is present, delegating to AsciidoctorJ default which is 'erb' (consistent with current docs).
Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!
What kind of change does this PR introduce? (check at least one)
For context, this was reported in the examples repo asciidoctor/asciidoctor-maven-examples#15 (comment)