Add compatibility with maven-site-plugin v3.20.0 #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump Doxia to same versions as maven-site-plugin * Apply required code changes
8 tasks
abelsromero
force-pushed
the
branch-main/933/add-compatibility-with-maven-site-plugin-v3.20.0
branch
from
7895513 to
ae15c4f
Compare
abelsromero
force-pushed
the
branch-main/933/add-compatibility-with-maven-site-plugin-v3.20.0
branch
from
c20fcc9 to
583bf59
Compare
abelsromero
force-pushed
the
branch-main/933/add-compatibility-with-maven-site-plugin-v3.20.0
branch
from
583bf59 to
bb43f6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Add compatibility with maven-site-plugin v3.20.0.
This requires code, tests and documentation changes due to breaking changes introduced by Doxia.
Are there any alternative ways to implement this?
We can try to get the code compatible with previous versions of maven-site-plugin.
But that would required doubling not only the code, but also tests due to changes in generated HTML.
For the sake of simplicity, if someone needs to use older maven-site-plugin, I'd rather do 3.0.x patch releases and keep 3.1.0 for maven-site 3.20.0
Are there any implications of this pull request? Anything a user must know?
Users wanting to use newer v3.1.0 will need to bump maven-site, and vice-versa.
Is it related to an existing issue?
#933