-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolves #6 add support for AsciiDoc table cells (including nested tables) #707
Conversation
b33d908
to
47be4aa
Compare
09753a5
to
32529cd
Compare
…g nested tables) - use custom Cell implementation to support AsciiDoc table cells - supports colspan, rowspan and vertical alignment - works best if column is assigned an explicit (relative) width - does not permit content that exceeds the height of one page - extra padding from last block is added to bottom of cell - does not (yet) inherit font properties from table cell
32529cd
to
cc4b63b
Compare
wow... I was having exactly this problem with lists in cells and I've seen it has been resolved 25 minutes ago! :-) |
The last published version of the Ruby gem is alpha.13. The last published version of AsciidoctorJ PDF jar is alpha.11. We're working on getting that deployment pipeline automated so that it's kept up to date with the Ruby version. Until then, I recommend configuring your build to use the gem via the JRuby plugin (for example, the JRuby Gradle plugin). See #572 (comment) or #650 (comment). |
Yeah, I saw the difference in published versions after I commented (I'm new to asciidoctor) I'd like to help but have no idea how :-/ Thanks for the links to those issues where you explain how to use a specific gem directly. Now I just need to wait for the gem with your latest commits fixing the table cell issue! |
A release of alpha.14 is coming very soon. I'm just in the process of wrapping up a few more issues. Here's the thread about the new AsciidoctorJ PDF repo. http://discuss.asciidoctor.org/New-repo-for-asciidoctorj-pdf-td4988.html Once that gets sorted out, then the releases should remain in sync. |
Is there documentation that would explain to a complete Ruby newbie, like me, how I would go about installing the current github in my Ruby environment? I need the fix for this to make progress on converting some of our docs, and the published alpha13 doesn't have it. |
@oddhack |
@barspi thanks! The build instructions are helpful but the other stuff about jruby / gradle doesn't seem directly relevant since I'm not using jruby (AFAIK - just the basic ruby-2.3.3 and related command-line tools accessed via rbenv). I guess once I have the 'gem' there's probably some way to bash on the 'gem install' command to access the local resource. This stuff is all pretty mystifying at my current state of understanding, compared to Debian package management. I'm sure it's wonderful once enough Ruby Kool-Aid has been consumed :-) |
It's my top priority to get alpha.14 released by this weekend. I got help up by a major workload in Jan that I'm just coming off of. Stay tuned...but don't hesitate to nudge me ;) |
That will be awesome. Looking forward to stress-testing asciidoc blocks in table cells! |
Also resolves duplicates #315, #445 and #358.