move previewContentProvider in the asciidoctorWebViewConverter

[ggrossetie]

This is a work in progress.
The main goal is to create a suitable HTML document for VS code. It will give us more control over the generated HTML. For instance, we can use a more fitting strategy to resolve the custom stylesheet path.

What I Did

• Create a suitable HTML document for VS code using a custom Asciidoctor converter (WebViewConverter)
• Bundle Noto Serif, Open Sans and Roboto mono fonts (ttf)
• Bundle Font Awesome (CSS + Fonts)
• Font Awesome can now be enabled using strict CSP and will work offline
• Replicate what the Markdown extension is doing to resolve relative paths (to stylesheets): https://github.com/microsoft/vscode/blob/3e5c7e2c570a729e664253baceaf443b69e82da6/extensions/markdown-language-features/src/features/previewContentProvider.ts#L147-L169
• Remove the stylesheet/stylesdir logic

TODO

• Reinstate MathJax. @danyill should we use bundle MathJax distribution?

[danyill]

This is great work, you are a 🚀
I have made a few comments on some of the questions.

[danyill]

LGTM, I tested a little. I don't really understand the changes in src/util/dispose.ts, can you give me a one liner?

[ggrossetie]

I don't really understand the changes in src/util/dispose.ts, can you give me a one liner?

I took the code from the Markdown extension. I believe we are using an outdated version of the code. I'm slowly trying to catch up/align with the latest version of the Markdown extension.
Disposable components will extend the abstract class Disposable (to hide all the _isDisposed and _disposables logic)

[ggrossetie]

@danyill not sure if we should commit MathJax files or ignore them (i.e., .gitignore) and copy/include them at build time?
We could do the same for Highlight.js and FontAwesome?

The downside is that it's harder to track changes. On the bright side, less files in the git history.

[ggrossetie]

I removed the files from Git.

[ggrossetie]

I also removed fonts from Git, they are now copied at build time from npm packages:

• https://www.npmjs.com/package/@fontsource/noto-serif
• https://www.npmjs.com/package/@fontsource/open-sans
• https://www.npmjs.com/package/@fontsource/roboto-mono

We might want to add an option to skip the copy-assets task when running thebuild task to save some time as we only need to run it once (except if we update the package.json file)