Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme with paste image section #925

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

leneffets
Copy link
Contributor

Hi there,

just an update on the readme.md. need to stumble over #208 to find out how pasting an image works ;-)

README.md Outdated

The extension provides a quick command to paste an image from clipboard.

* Create a screenshot thats in the clipboard
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be too specific? "Copy an image in your clipboard" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, great idea! This is the more generic approach. My usecase actually was: take a screenshot and put in in a adoc document.
But put an image to clipboard is more versatile, should also work e.g. for remote sessions on other hosts.

* Open the command palette - `ctrl+shift+p` or `F1` (Mac: `cmd+shift+p`)
* Select _AsciiDoc: Paste Image_ (or use the shortcut `ctrl+alt+v`, Mac: `option+cmd+v`)
* The png file with current timestamp is generated in the same folder
* in the working document an image macro is inserted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last 2 bullets are not actions that the user must take, so I will probably convert them to a paragraph to describe what the user should see. What do you think?

Copy link
Contributor Author

@leneffets leneffets Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked on the previous headings. They also have bullets with "The file is generated ... " so there may be some consistency with the other features. i just wanted to point out what the feature is describe the outcome.

What do you think about this one sentence, instead of the two? Seems shorter and more generic.
Generates a timestamped image and inserts an image macro into the document.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm good point, you're right we should probably be consistent. Since we are using passive sentence it should be:

An image file, named with a timestamp, is created, and an image macro is added to the document

Anyway, it really is a nitpick. Thanks for updating the documentation, I really appreciate it!

leneffets and others added 2 commits December 18, 2024 14:59
Co-authored-by: Guillaume Grossetie <[email protected]>
* Open the command palette - `ctrl+shift+p` or `F1` (Mac: `cmd+shift+p`)
* Select _AsciiDoc: Paste Image_ (or use the shortcut `ctrl+alt+v`, Mac: `option+cmd+v`)
* The png file with current timestamp is generated in the same folder
* in the working document an image macro is inserted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm good point, you're right we should probably be consistent. Since we are using passive sentence it should be:

An image file, named with a timestamp, is created, and an image macro is added to the document

Anyway, it really is a nitpick. Thanks for updating the documentation, I really appreciate it!

@ggrossetie ggrossetie merged commit 88ea2d3 into asciidoctor:master Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants