This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
Made scrolling smooth on Android when parent updates index prop during pan #399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When a user releases a photo while panning on Android, the next image isn't smoothly animated in.
Cause/debugging
index
prop from within theonChange
handler of the parent componentgoNext
orgoPrevious
, which also calls theonChange
handleronChange
callback, the parent updates theindex
. this causescomponentDidUpdate
to calljumpToCurrentImage
jumpToCurrentImage
callssetValue
, which immediately cancels the animationFix
Make
jumpToCurrentImage
not callsetValue
if it's already animating to the right placeTesting
In a test app on Android: