support integer-1.1 and ndarray-1.1 #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2022
|
Now that asdf-format/asdf-standard#350 is merged can you Remove the skips added in #1251 and #1252? |
braingram
force-pushed
the
bug/ndarray_schema
branch
from
4803458 to
e8356e1
Compare
braingram
commented
Nov 30, 2022
asdf/tests/test_versioning.py
Outdated
Comment on lines
278
to
303
| version = request.getfixturevalue("version") | ||
| if (version, tag) in [ | ||
| ("1.6.0", "tag:stsci.edu:asdf/core/column-1.1.0"), | ||
| ("1.6.0", "tag:stsci.edu:asdf/core/integer-1.1.0"), | ||
| ("1.6.0", "tag:stsci.edu:asdf/core/ndarray-1.1.0"), | ||
| ("1.6.0", "tag:stsci.edu:asdf/core/table-1.1.0"), | ||
| ("1.6.0", "tag:stsci.edu:asdf/fits/fits-1.1.0"), | ||
| ("1.6.0", "tag:stsci.edu:asdf/time/time-1.2.0"), | ||
| ("1.6.0", "tag:stsci.edu:asdf/unit/defunit-1.0.0"), | ||
| ("1.6.0", "tag:stsci.edu:asdf/unit/defunit-1.1.0"), | ||
| ("1.6.0", "tag:stsci.edu:asdf/unit/quantity-1.2.0"), | ||
| ("1.6.0", "tag:stsci.edu:asdf/unit/unit-1.1.0"), |
|
It looks like this will require either a release of asdf-standard or refactoring test_builtin_extension (and readding one of the xfails for defunit). |
This was referenced Nov 30, 2022
braingram
force-pushed
the
bug/ndarray_schema
branch
from
8f1e0cd to
940a736
Compare
WilliamJamieson
suggested changes
Dec 13, 2022
Comment on lines
+137
to
+144
| raise RuntimeError( | ||
| "Subclasses of ExtensionTypeMeta that define " | ||
| "supported_versions cannot used super() to call " | ||
| "parent class functions. super() creates a " | ||
| "__classcell__ closure that cannot be duplicated " | ||
| "during creation of versioned siblings. " | ||
| "See https://github.com/asdf-format/asdf/issues/1245" | ||
| ) |
There was a problem hiding this comment.
Can you write a test that raises this error?
There was a problem hiding this comment.
Sure thing. I added one to 80d5904
fixes an issue with integer where InterType instead of cls was used during class instantiation which resulted in objects being created with the incorrect version. Prior code (that only had one integer version, 1.0) did not suffer from issues because of this bug. fixes asdf-format#1245 by removing the use of super in NDArrayType and adding an exception to check for incompatible use of super in classes of type ExtensionTypeMeta.
braingram
force-pushed
the
bug/ndarray_schema
branch
from
91bd3da to
80d5904
Compare
WilliamJamieson
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes an issue with integer where IntegerType instead of cls was used during class instantiation which resulted in objects being created with the incorrect version. Prior code (that only had one integer version, 1.0) did not suffer from issues because of this bug.
fixes #1245 by removing the use of super in NDArrayType and adding an exception to check for incompatible use of super in classes of type ExtensionTypeMeta.
This should be merged with asdf-standard PR asdf-format/asdf-standard#350