skip testing type versions not in any deployed standard #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might make more sense to add this to #1250 so we can verify it passes CI. If the CI here passes we'll at least have confirmation that it didn't add any new failures to the master branch. |
WilliamJamieson
suggested changes
Dec 1, 2022
braingram
force-pushed
the
testing/skip_development_version_types
branch
2 times, most recently
from
c24b747 to
23b6b98
Compare
WilliamJamieson
approved these changes
Dec 12, 2022
braingram
force-pushed
the
testing/skip_development_version_types
branch
from
23b6b98 to
ea19f3a
Compare
|
close/reopen to attempt to reset doc build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies _assert_extension_type_correctness to skip checking type versions that are not part of a non-development supported version of the asdf-standard.
Two other tests are added
test_default_in_supported_versionsandtest_development_is_not_defaultto catch possible errors where the default is set to a non-supported (or development) version.As this PR will skip testing completeness (that a type has a schema of the same version) of type versions that are only in development version, it's possible that updating the development version of the asdf-standard will cause test failures if the schema and type versions do not match. Put another way, a PR that advances the asdf-standard development version might reveal and then have to fix these type/schema version issues.
This should allow PR #1250 to pass CI without an asdf-standard release.