deprecation asdf.extension legacy functions #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
force-pushed
the
deprecate/legacy_extension_functions
branch
from
7925b8c to
556ca26
Compare
15 tasks
braingram
force-pushed
the
deprecate/legacy_extension_functions
branch
from
3db9378 to
3644b9d
Compare
WilliamJamieson
suggested changes
Feb 21, 2023
braingram
force-pushed
the
deprecate/legacy_extension_functions
branch
from
3644b9d to
9872c60
Compare
deprecates: - default_extensions - get_default_resolver - get_cached_asdf_extension_list
pytest_asdf was accessing asdf.extensions.default_extensions and then accessing the resolver attribute and passing it to load_schema as the resolver argument. This produces a resolver argument that is identical to the default. This commit removes the uneeded work and instead allows use of the identical default.
astropy tests named test_backwards_compat in astropy/io/misc/asdf/tags/fits/tests/test_fits.py and astropy/io/misc/asdf/tags/table/tests/test_table.py fail due to use of default_extensions in astropy/io/misc/asdf/tags/tests/helpers.py
braingram
force-pushed
the
deprecate/legacy_extension_functions
branch
from
9872c60 to
67eb3f3
Compare
for more information, see https://pre-commit.ci
|
To avoid confusion in |
At the moment I don't object to waiting. I started #1429 based off the changes included in this PR. Are there changes requested? If not, I will mark #1429 as ready for review and update #1361 based off the changes in #1429. |
WilliamJamieson
approved these changes
Feb 22, 2023
|
This is ready aside from waiting for the astropy PR to clear. |
meeseeksmachine
pushed a commit
to meeseeksmachine/asdf
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecates several helper functions/attributes exposed via
asdf.extensionsthat are related to only the legacy extension api: