Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more warnings for asdf #14433

Merged

Conversation

WilliamJamieson
Copy link
Contributor

Description

asdf-format/asdf#1409 introduced more deprecations affecting astropy. This PR "fixes" those

@WilliamJamieson WilliamJamieson added no-changelog-entry-needed 💤 backport-v5.0.x on-merge: backport to v5.0.x 💤 backport-v5.2.x on-merge: backport to v5.2.x labels Feb 22, 2023
@WilliamJamieson WilliamJamieson added this to the v5.0.6 milestone Feb 22, 2023
@github-actions github-actions bot added the 💤 io.misc.asdf Go to asdf-astropy repo label Feb 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2023

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@WilliamJamieson WilliamJamieson force-pushed the bugfix/asdf_legacy_method_deprecations branch from 8f1fd2a to 20f924e Compare February 22, 2023 17:48
@WilliamJamieson WilliamJamieson marked this pull request as ready for review February 22, 2023 18:05
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim
Copy link
Member

pllim commented Feb 22, 2023

Don't have to wait for 32-bit job. Merging.

@pllim pllim merged commit eaa66cc into astropy:main Feb 22, 2023
@lumberbot-app

This comment was marked as resolved.

meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Feb 22, 2023
@WilliamJamieson WilliamJamieson deleted the bugfix/asdf_legacy_method_deprecations branch February 22, 2023 18:20
WilliamJamieson added a commit to WilliamJamieson/astropy that referenced this pull request Feb 22, 2023
pllim added a commit that referenced this pull request Feb 22, 2023
Backport PR #14433 on branch v5.0.x (Fix more warnings for asdf)
pllim added a commit that referenced this pull request Feb 22, 2023
…433-on-v5.2.x

Backport PR #14433 on branch v5.2.x (Fix more warnings for asdf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed 💤 backport-v5.0.x on-merge: backport to v5.0.x 💤 backport-v5.2.x on-merge: backport to v5.2.x 💤 io.misc.asdf Go to asdf-astropy repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants