Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer warn but raise an exception for converters with more than 1 tag that don't implement select tag #1632

Closed
braingram opened this issue Aug 17, 2023 · 0 comments · Fixed by #1853
Closed

No longer warn but raise an exception for converters with more than 1 tag that don't implement select tag #1632

braingram opened this issue Aug 17, 2023 · 0 comments · Fixed by #1853
Milestone
4.0.0

Comments

@braingram
Copy link
Contributor

To provide backwards compatibility changes were added to:
#1594
where including a converter (that inherits from Converter) in an extension which results in the converter having more than 1 tag causes a warning.

For the next major version we should turn this into an error (as mentioned in the warning message).
@braingram braingram added this to the 4.0.0 milestone Aug 17, 2023
@braingram braingram changed the title No longer warn but raise an exception for converters with more than 1 tag that don't implement selec tag No longer warn but raise an exception for converters with more than 1 tag that don't implement select tag Sep 26, 2023
@braingram braingram mentioned this issue Oct 28, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Error for Convert subclasses with multiple tags if select_tag isn't implemented braingram/asdf
1 participant
@braingram