Error for Convert subclasses with multiple tags if select_tag isn't implemented #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
changed the title
braingram
force-pushed
the
err_select_tag
branch
from
201854b to
583034e
Compare
Thanks for the review! Soon this repo will be empty *wrings hands maniacally* |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1632
For a converter that supports multiple tags but does not implement select tag, raise a RuntimeError (instead of a warning). Previously a warning was produced only for
Convertersubclasses (virtual subclasses produced RuntimeErrors). Now both real and virtual subclasses produce errors.Checklist:
pre-commit checks ran successfully
tests ran successfully
for a public change, added a towncrier news fragment
changes/<PR#>.<changetype>.rstchanges/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: bug fixchanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.general.rst: infrastructure or miscellaneous changefor a public change, updated documentation
for any new features, unit tests were added