Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop .tree from search result paths #954

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Drop .tree from search result paths #954

merged 1 commit into from
Mar 24, 2021

Conversation

eslavich
Copy link
Contributor

The .tree is unnecessary given that we have an AsdfFile.__getitem__ defined.

Resolves #875

@eslavich eslavich requested a review from jdavies-st March 23, 2021 21:05
jdavies-st
jdavies-st approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@jdavies-st jdavies-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@eslavich eslavich merged commit 6261382 into asdf-format:master Mar 24, 2021
@eslavich eslavich deleted the eslavich-no-tree-in-search-result-paths branch March 24, 2021 15:56
@eslavich eslavich added this to the 2.8.0 milestone Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdavies-st jdavies-st jdavies-st approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

Don't bother showing .tree in search result paths
2 participants
@eslavich @jdavies-st