Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #1487: add upper pin to jsonschema #1489

Conversation

WilliamJamieson
Copy link
Contributor

Backport of #1487 for jsonschema pin

@WilliamJamieson WilliamJamieson force-pushed the backport/jsonschema_pin_2.14 branch from 4e229ac to 66a7118 Compare March 17, 2023 13:35
@WilliamJamieson
Copy link
Contributor Author

The weldx and stdatamodels failures look expected (this CI has not been run in awhile).

Copy link
Contributor

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment on the default branch names. Thanks for the quick response.

.github/workflows/ci.yml Show resolved Hide resolved
@braingram
Copy link
Contributor

@WilliamJamieson Is this ready to merge? @pllim is asking about a 2.14 release with this to deal with astropy CI failures.

@pllim
Copy link
Contributor

pllim commented Mar 20, 2023

Even a pre-release would be ok. Our CI downstream is testing against pre-releases. Thanks!

@WilliamJamieson WilliamJamieson merged commit efafac8 into asdf-format:2.14.x Mar 20, 2023
@WilliamJamieson WilliamJamieson deleted the backport/jsonschema_pin_2.14 branch March 20, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants