Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix masked array class path for numpy 2.0 #1769

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

braingram
Copy link
Contributor

Numpy 2.0 moved the internal path for np.ma.MaskedArray. See: numpy/numpy@7b9dede

This causes masked arrays to be saved as standard numpy arrays with a warning. See:
https://github.com/astropy/asdf-astropy/actions/runs/8222457553/job/22484029609?pr=219#step:10:291

This PR updates the converter to be aware of the new path.

I believe #1654 would have prevented this failure (by allowing for the public class path).

Description

Checklist:

  • pre-commit checks ran successfully
  • tests ran successfully
  • for a public change, a changelog entry was added
  • for a public change, documentation was updated
  • for any new features, unit tests were added

Sorry, something went wrong.

@braingram braingram marked this pull request as ready for review March 10, 2024 14:56
@braingram braingram requested a review from a team as a code owner March 10, 2024 14:56

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@braingram
Copy link
Contributor Author

Compatibility tests addressed in: #1771

@braingram
Copy link
Contributor Author

Thanks!

@braingram braingram merged commit aedf156 into asdf-format:main Mar 11, 2024
32 of 34 checks passed
@braingram braingram deleted the masked_array branch March 11, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants