-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement AsdfVersion class #284
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remember to update |
This allows for an intuitive comparision AsdfSpec with AsdfVersion, or with strings and tuples that represent versions.
This now resolves #280 as well (as requested by @perrygreenfield) and allows supported versions to be expressed in terms of unbounded ranges (e.g. |
Since this revision removes the extern package |
This was referenced Aug 3, 2017
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR directly resolves #279 by implementing a new type
AsdfVersion
that is used to represent all schema version information. It also implements anAsdfSpec
class that will be used to represent ranges of versions, which was requested in #280.This also directly resolves #283, in that it replaces the extern package
semver
withsemantic_version
, which is now a dependency that is expressed insetup.py
. It indirectly closes #282 since we no longer want to addsemver
as a real dependency.I intend to directly address #280 before closing this PR.
[edit]
Now fixes #280 too.