Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AsdfVersion class #284

Merged
merged 10 commits into from
Aug 7, 2017
Merged

Conversation

drdavella
Copy link
Contributor

@drdavella drdavella commented Jul 26, 2017

This PR directly resolves #279 by implementing a new type AsdfVersion that is used to represent all schema version information. It also implements an AsdfSpec class that will be used to represent ranges of versions, which was requested in #280.

This also directly resolves #283, in that it replaces the extern package semver with semantic_version, which is now a dependency that is expressed in setup.py. It indirectly closes #282 since we no longer want to add semver as a real dependency.

I intend to directly address #280 before closing this PR.

[edit]
Now fixes #280 too.

@drdavella drdavella self-assigned this Jul 26, 2017
@drdavella
Copy link
Contributor Author

Remember to update CHANGES.rst

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 94.385% when pulling cf116ab on drdavella:asdf-version into fd5ea50 on spacetelescope:master.

@drdavella drdavella requested review from mdboom and removed request for mdboom July 31, 2017 15:44
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 94.373% when pulling e6c7650 on drdavella:asdf-version into fd5ea50 on spacetelescope:master.

@drdavella
Copy link
Contributor Author

This now resolves #280 as well (as requested by @perrygreenfield) and allows supported versions to be expressed in terms of unbounded ranges (e.g. >=X.Y.Z).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 94.384% when pulling 1f76d9e on drdavella:asdf-version into 44b6a10 on spacetelescope:master.

@drdavella
Copy link
Contributor Author

Since this revision removes the extern package semver, is it also okay to remove the license file licenses/LICENSE-semver.rst? It seems like the answer should be yes but I'm not really sure.

This was referenced Aug 3, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 94.465% when pulling 7b02d52 on drdavella:asdf-version into 44b6a10 on spacetelescope:master.

@drdavella drdavella merged commit 358e7ea into asdf-format:master Aug 7, 2017
@drdavella drdavella deleted the asdf-version branch August 7, 2017 20:14
@nden nden mentioned this pull request Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants