Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for AsdfFile.update in readonly mode #587

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

drdavella
Copy link
Contributor

This resolves #469.

Thanks to #579, this error should occur less often since by default asdf.open will attempt to determine the appropriate write mode for the file. In most cases, the default mode will be 'rw'.

@stsci-bot
Copy link

stsci-bot bot commented Nov 1, 2018

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

1 similar comment
@stsci-bot
Copy link

stsci-bot bot commented Nov 1, 2018

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.684% when pulling 272fb94 on drdavella:better-error-msg into 414ad9d on spacetelescope:master.

@drdavella drdavella merged commit 8f69609 into asdf-format:master Nov 1, 2018
@drdavella drdavella deleted the better-error-msg branch November 1, 2018 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When raising OSError, AsdfFile.update should highlight why associated file is read-only
2 participants