Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against legacy and prerelease versions of dependencies #661

Merged
merged 4 commits into from
Mar 15, 2019

Conversation

drdavella
Copy link
Contributor

This resolves #660.

@drdavella drdavella added this to the v2.3.3 milestone Mar 15, 2019
@drdavella drdavella self-assigned this Mar 15, 2019
@stsci-bot
Copy link

stsci-bot bot commented Mar 15, 2019

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

2 similar comments
@stsci-bot
Copy link

stsci-bot bot commented Mar 15, 2019

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@stsci-bot
Copy link

stsci-bot bot commented Mar 15, 2019

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@drdavella drdavella force-pushed the test-legacy-and-prerelease branch from dfa0adc to 6798040 Compare March 15, 2019 19:04
@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #661 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #661   +/-   ##
=======================================
  Coverage   93.24%   93.24%           
=======================================
  Files          39       39           
  Lines        4295     4295           
=======================================
  Hits         4005     4005           
  Misses        290      290

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a5c6f...6798040. Read the comment docs.

@drdavella drdavella merged commit 3871f34 into asdf-format:master Mar 15, 2019
@drdavella drdavella deleted the test-legacy-and-prerelease branch March 15, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test against prerelease versions of pyyaml and jsonschema
1 participant