Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ninja #141

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Add ninja #141

merged 2 commits into from
Oct 8, 2019

Conversation

smorimoto
Copy link
Member

No description provided.

@smorimoto
Copy link
Member Author

Build Status: Build Status

@Stratus3D
Copy link
Member

Thanks for the PR!

A couple things I noticed when reviewing the code and one thing I think should be changed. The multi line echo printing help after installation should be removed. Instructions and documentation should not be printed during or after installation. We are soon going to have a separate script the user can invoke for docs (asdf-vm/asdf#552). You should be able to get by without jq. Users may not have it installed. I use sed for extracting versions from the Github JSON in my plugins.

Other than the multiple echos after installation I the plugin looks good and I will merge once that code is removed.

@smorimoto
Copy link
Member Author

@Stratus3D I updated all plugins! and I will remove jq.

@Stratus3D
Copy link
Member

@imbsky awesome! Thanks for the plugin.

@Stratus3D Stratus3D merged commit 248154e into asdf-vm:master Oct 8, 2019
@smorimoto smorimoto deleted the patch-1 branch October 8, 2019 15:12
@smorimoto
Copy link
Member Author

Anytime!

@smorimoto
Copy link
Member Author

I removed jq from prerequirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smorimoto @Stratus3D