Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Option "-k" to keep source #74

Closed
HashNuke opened this issue Jun 30, 2016 · 3 comments · Fixed by #669
Closed

[Proposal] Option "-k" to keep source #74

HashNuke opened this issue Jun 30, 2016 · 3 comments · Fixed by #669

Comments

@HashNuke
Copy link
Member

HashNuke commented Jun 30, 2016

Inspired by ruby-build's -k option.

Passing this option should uncompress and compile the package in ~/.asdf/sources/<plugin>/<version> instead of the tmp dir. This is plugin specific.

asdf install ruby 2.3.0 -k
  • If -k is passed the plugin's install script is passed a source-compile path as another argument.
  • The plugin's install script uses a temp or the source-compile path to compile the package depending on the option passed.

Atleast for now, this would make it possible to use gdb with ruby. I have this work-in-progress in the keep-source branch.

@HashNuke HashNuke self-assigned this Jun 30, 2016
@HashNuke
Copy link
Member Author

HashNuke commented Jul 1, 2016

keep-source support is now in the keep-source branch of asdf and asdf-ruby.

Setting KEEP_SOURCE=1 when installing a ruby will preserve the source in ~/.asdf/sources/ruby/<version>

This helped with using ruby with gdb. If I can get getopt working with bash, I'll send a PR after adding the -k option.

EDIT: Comment originally posted from phone. Updated markup.

@danhper
Copy link
Member

danhper commented Jul 1, 2016

Nice! I think this would make sense for Python too, I will add the option to my plugin when you are done here!

@jayvdb
Copy link

jayvdb commented Nov 27, 2018

I think this should actually be the default, and another command is added to cleanup unneeded source & build dirs.

e.g. I just installed Python, but I didnt have sqlite3-devel installed, resulting in

Downloading Python-3.6.7.tar.xz...
-> https://www.python.org/ftp/python/3.6.7/Python-3.6.7.tar.xz
Installing Python-3.6.7...
WARNING: The Python sqlite3 extension was not compiled. Missing the SQLite3 lib?

After installing the devels, asdf needs to refetch everything, and rebuild everything, which is wasted bytes and time.

@Stratus3D Stratus3D self-assigned this Feb 25, 2020
@Stratus3D Stratus3D mentioned this issue Mar 7, 2020
@jthegedus jthegedus added this to the v0.8.x milestone Aug 20, 2020
Stratus3D added a commit that referenced this issue Dec 16, 2024
feat(golang-rewrite): more `asdf plugin remove` tests
Stratus3D added a commit that referenced this issue Dec 18, 2024
feat(golang-rewrite): more `asdf plugin remove` tests
Stratus3D added a commit that referenced this issue Dec 18, 2024
feat(golang-rewrite): more `asdf plugin remove` tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants