Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test if plugin can be updated. #153

Closed
wants to merge 1 commit into from

Conversation

fazibear
Copy link

@fazibear fazibear commented Feb 10, 2017

Just in case of

error: cannot pull with rebase: You have unstaged changes.
error: please commit or stash them.

@Stratus3D
Copy link
Member

Thanks for the PR @fazibear but this is something we've discussed on #124. I think it will be better to address the root cause (permission changes) rather than printing an error. Ideally a plugin update should only fail due to network issues. I think currently the error makes it to STDOUT when that happens.

@fazibear
Copy link
Author

fazibear commented Feb 12, 2017

I saw it, but testing it like this #138 is pointless because it is already changed during plugin-add process https://github.com/asdf-vm/asdf/blob/master/lib/commands/plugin-add.sh#L19

@Stratus3D
Copy link
Member

@fazibear correct, and that has been fixed with #154.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants