WIP: Bash Strict Mode #520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stratus3D
force-pushed
the
tb/bash-strict-mode
branch
from
d8f7573 to
aa8768c
Compare
|
I've got one failing test locally, but nearly all the tests fail on Travis.CI and I'm not sure why. |
Stratus3D
force-pushed
the
tb/bash-strict-mode
branch
from
5077aaa to
9eff4b0
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Bash strict mode to all Bash script that are not sourced directly by the user.
We can't add Bash script mode to any files the user may source, or may get sourced by any other scripts, as the strict mode settings will leak into other contexts. I've had to make some changes to a few of the tests that emulate a user shell to get around this in the tests.
Fixes: #160, #247