Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ash::vk::make_version should be deprecated and ash::vk::make_api_version should take its place #428

Closed
AlexApps99 opened this issue May 2, 2021 · 1 comment · Fixed by #417 or #431

Comments

@MarijnS95
Copy link
Collaborator

MarijnS95 commented May 2, 2021

This only becomes relevant when Vulkan 1.2.175 is supported by Ash, where this deprecation happened. The current open PR for that silently makes the deprecated ones disappear.

I've been playing around with autogenerating #defines including proper handling of links and deprecation warnings, and the result is pretty neat IMO: https://github.com/MaikKlein/ash/commits/autgenerate-define-exprs. The code may be a bit brittle, but that should be okay given that this generator is on its way out anyway. More interesting, regenerating .175 with this method puts everything in the right spot automatically: 0c29066#diff-de84e0b739496d075bbbbe18e9ff5c7b444f0b8bfe2160b07c998ead1b200844R9-R57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants