generator: Parse and autogenerate version-related defines #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
May 8, 2021
Comment on lines
+45
to
+51
| value!(CType::U64, complete!(tag!("ULL"))) | | ||
| value!(CType::U32, complete!(tag!("U"))) |
There was a problem hiding this comment.
This was never working before: the longest prefix needs to be matched first but at the same time that sets the minimum length requirement for the rest of the alt!, so tag!("U") never got matched.
Documented here, perhaps this should be a comment in-line:
https://github.com/Geal/nom/blob/38bb94e7bc45c2b4ef0c473e0e5c03ab134cdff3/src/branch/macros.rs#L93-L142
MarijnS95
force-pushed
the
autgenerate-define-exprs
branch
3 times, most recently
from
0be6b4b to
3773123
Compare
MarijnS95
force-pushed
the
autgenerate-define-exprs
branch
from
3773123 to
f721c41
Compare
Ralith
approved these changes
May 11, 2021
MarijnS95
force-pushed
the
autgenerate-define-exprs
branch
2 times, most recently
from
97b1dca to
56617f4
Compare
MarijnS95
changed the title
MarijnS95
force-pushed
the
autgenerate-define-exprs
branch
from
56617f4 to
b84eb45
Compare
With more and more version-related defines showing up this saves us a bunch of time.
MarijnS95
force-pushed
the
autgenerate-define-exprs
branch
from
b84eb45 to
7e10b88
Compare
MaikKlein
approved these changes
May 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #429
With this PR I want to leverage existing parsing and generation infrastructure to completely automate the generation of define macros. It doesn't change much right now but will address #428 as if by magic when generating for
.175🥳Things we should discuss:
SHOUTY_SNAKE_CASE- this isn't standard forconst fn. We previously had a map to re-mapVK_MAKE_VERSIONtomake_versionbut to do this consistently in this new system we'll have to collect a set ofSHOUTY_SNAKE_CASEidentifiers that were found to beconst fn(!define.parameters.is_empty()) intead and map those tosnake_case;EDIT: This is now taken care of by a map, bit verbose but we do that for many other types too;
cexprvshexadecimal_number. Both can probably emit aLiteralorTokenStreamat this point.