-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Implement extension chaining #183
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
681eec5
Update to 1.1.97
MaikKlein 6d72bb5
Implement extension chaining
MaikKlein c46a41e
Replace `ExtensionChain` with a simple iterator
MaikKlein 4f7ca18
Implement `push_next`
MaikKlein 3de2ca9
Implement `ExtendsXXX` for all builders as well
MaikKlein c66ae6b
Add lifetime to push_next
MaikKlein 1e13b99
Add some documentation to `push_next`
MaikKlein d6a6aa3
Update experimental AMD extension
MaikKlein 38fe16f
Use repr transparent for builders
MaikKlein 215511f
Implement ExtendXXX for multiple root create infos
MaikKlein 04dbf20
Transform the ptr chain sample into a test case
MaikKlein 2ecc483
Reformat experimental amd
MaikKlein 4c1c8aa
Remove mut
MaikKlein 88b1ac0
Rename root_extends
MaikKlein d667e58
Add example
MaikKlein bf29ebb
Replace root create info with root_struct
MaikKlein c8c8f69
`next` can contain a pointer chain and we need to correct insert it.
MaikKlein 1744159
Move ptr chain tests out of the generator
MaikKlein 2d730cd
Add ptrchain external test file
MaikKlein 7d5d200
Move external tests to lib.rs
MaikKlein cbc96b2
Update experimental builders
MaikKlein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused about where this definition is coming from. It's missing the chain support added to the generated version. I guess it's hand-written? Is that necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is handwritten. I am not sure what we should do about it. Maybe we should remove all the builder stuff because it will probably get out of date anyway?
I am going to update it anyway.
Everything in experimental won't adhere to semver, so we can remove some parts in the future. I probably should document that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker, then, but why isn't this generated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this is not included in the vk.xml. That is why it is inside the experimental module. @msiglreith basically reversed the API :). This will be deleted when it is officially included in the vk.xml.