Pass constant size arrays by reference

[kvark]

Note: this is a breaking change!
Some related reading: https://lkml.org/lkml/2015/9/3/428
This has been plaguing WebRender on gfx-rs port running Windows/Vulkan.

[MaikKlein]

Interesting, thanks for the catch!

I also leave here the current implementation for it in radv. Indeed it is just used as a pointer.

void radv_CmdSetBlendConstants(
	VkCommandBuffer                             commandBuffer,
	const float                                 blendConstants[4])
{
	RADV_FROM_HANDLE(radv_cmd_buffer, cmd_buffer, commandBuffer);
	struct radv_cmd_state *state = &cmd_buffer->state;

	if (!memcmp(state->dynamic.blend_constants, blendConstants, sizeof(float) * 4))
		return;

	memcpy(state->dynamic.blend_constants, blendConstants, sizeof(float) * 4);

	state->dirty |= RADV_CMD_DIRTY_DYNAMIC_BLEND_CONSTANTS;
}

[MaikKlein]

bors r+

[bors]

Build succeeded

• continuous-integration/appveyor/branch
• continuous-integration/travis-ci/push

[kvark]

Thank you! Any plans to release a version with this fix?

…

On Mar 8, 2019, at 03:49, bors[bot] ***@***.***> wrote: Merged #191 into master. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[MaikKlein]

There are currently a few breaking changes in place, I'll push a new version after #183 is merged, which should be today. (hopefully)

[kvark]

Great, thanks!

…

On Mar 8, 2019, at 10:31, Maik Klein ***@***.***> wrote: There are currently a few breaking changes in place, I'll push a new version after #183 is merged, which should be today. (hopefully) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.