extensions/ext: Add VK_EXT_acquire_drm_display #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
reviewed
Oct 11, 2022
55 tasks
MarijnS95
reviewed
Oct 11, 2022
| drm_fd: i32, | ||
| connector_id: u32, | ||
| ) -> VkResult<vk::DisplayKHR> { | ||
| let mut display = mem::MaybeUninit::uninit(); |
There was a problem hiding this comment.
We've only sparsely used MaybeUninit before (only ever in VK_KHR_display), and only with zeroed() instead of uninit().
Doesn't seem like there's any harm in doing that here, so I'm willing to try that out (and hopefully schedule to replace more MaybeUninit::zeroed()/mem::zeroed()/default() calls at some point).
MarijnS95
approved these changes
Oct 11, 2022
Ralith
reviewed
Oct 12, 2022
MarijnS95
pushed a commit
that referenced
this pull request
Oct 16, 2022
Co-authored-by: Aidan Prangnell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that KhronosGroup/Vulkan-ValidationLayers#4136 prevents the use of
vkGetDrmDisplayEXTwhile usingVK_LAYER_KHRONOS_validation.